xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 09 Sep 2014 17:33:30 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140909222856.GA27349@xxxxxxxxxxxxx>
References: <1410108065-18156-1-git-send-email-sandeen@xxxxxxxxxx> <1410108065-18156-2-git-send-email-sandeen@xxxxxxxxxx> <20140909222856.GA27349@xxxxxxxxxxxxx>
On 9/9/14 5:28 PM, Christoph Hellwig wrote:
On Sun, Sep 07, 2014 at 11:41:01AM -0500, Eric Sandeen wrote:
process_dinode_int() reports bad flags if
dino->di_flags & ~XFS_DIFLAG_ANY - i.e. if
any flags are set outside the known set.  But
then instead of clearing them, it does
flags &= ~XFS_DIFLAG_ANY which keeps *only*
the bad flags.  This leads to persistent,
unrepairable errors of the form:

You know you can use up to 75 characters per line for your commit messages,
don't you? :)

hah, it's not automated at all, I guess my visual perception
of the window is shrinking.  Dave, feel free to fix on commit if
inclined :)

-Eric

<Prev in Thread] Current Thread [Next in Thread>