| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 9 Sep 2014 15:28:56 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1410108065-18156-2-git-send-email-sandeen@xxxxxxxxxx> |
| References: | <1410108065-18156-1-git-send-email-sandeen@xxxxxxxxxx> <1410108065-18156-2-git-send-email-sandeen@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Sun, Sep 07, 2014 at 11:41:01AM -0500, Eric Sandeen wrote: > process_dinode_int() reports bad flags if > dino->di_flags & ~XFS_DIFLAG_ANY - i.e. if > any flags are set outside the known set. But > then instead of clearing them, it does > flags &= ~XFS_DIFLAG_ANY which keeps *only* > the bad flags. This leads to persistent, > unrepairable errors of the form: You know you can use up to 75 characters per line for your commit messages, don't you? :) Otherwise looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: Corrupted files, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int, Brian Foster |
| Next by Thread: | Re: [PATCH 1/5] xfs_repair: clear bad flgs in process_dinode_int, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |