On Tue, Sep 02, 2014 at 10:08:13AM -0400, Brian Foster wrote:
> Here's v2 of the log recovery delay instrumentation set. v1 is available
> here:
>
> http://oss.sgi.com/archives/xfs/2014-08/msg00276.html
>
> After a brief conversation with Dave, we thought it best to tie in this
> functionality with DEBUG mode to express/ensure that these attributes
> are for debugging/hacking purposes only. Everything else should be
> equivalent to v1.
>
> Brian
>
> v2:
> - Enable /sys/fs/xfs/debug for DEBUG mode kernels only.
> v1: http://oss.sgi.com/archives/xfs/2014-08/msg00276.html
>
> Brian Foster (2):
> xfs: add debug sysfs attribute set
> xfs: export log_recovery_delay to delay mount time log recovery
These look good. I'm sure that as we add more attributes there will
be opportunity for factoring/streamlining this code more, but right
now I don't think that is necessary.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
|