xfs
[Top] [All Lists]

Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_at

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 2/5] xfs_repair: preserve error state in process_shortform_attr
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Mon, 8 Sep 2014 09:45:19 -0400
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1410108065-18156-3-git-send-email-sandeen@xxxxxxxxxx>
References: <1410108065-18156-1-git-send-email-sandeen@xxxxxxxxxx> <1410108065-18156-3-git-send-email-sandeen@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Sun, Sep 07, 2014 at 11:41:02AM -0500, Eric Sandeen wrote:
> process_shortform_attr uses the "junkit" error to
> track whether an error was found, but by assigning
> it directly to the result of valuecheck, previous
> errors are ignored, leading to unrepairable errors
> of the form i.e.
> 
> "entry has INCOMPLETE flag on in shortform attribute"
> or
> "entry contains illegal character in shortform attribute name"
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Reviewed-by: Brian Foster <bfoster@xxxxxxxxxx>

>  repair/attr_repair.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/repair/attr_repair.c b/repair/attr_repair.c
> index a27a3ec..d60b664 100644
> --- a/repair/attr_repair.c
> +++ b/repair/attr_repair.c
> @@ -914,7 +914,8 @@ process_shortform_attr(
>  
>               /* Only check values for root security attributes */
>               if (currententry->flags & XFS_ATTR_ROOT)
> -                    junkit = valuecheck(mp, (char 
> *)&currententry->nameval[0],
> +                    junkit |= valuecheck(mp,
> +                                     (char *)&currententry->nameval[0],
>                                       NULL, currententry->namelen, 
>                                       currententry->valuelen);
>  
> -- 
> 1.7.1
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>