xfs
[Top] [All Lists]

Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype

To: Dave Chinner <david@xxxxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 4/5] xfs_repair: don't ASSERT on corrupt ftype
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 07 Sep 2014 20:02:20 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140908001044.GB30012@dastard>
References: <1410108065-18156-1-git-send-email-sandeen@xxxxxxxxxx> <1410108065-18156-5-git-send-email-sandeen@xxxxxxxxxx> <20140908001044.GB30012@dastard>
On 9/7/14 7:10 PM, Dave Chinner wrote:
On Sun, Sep 07, 2014 at 11:41:04AM -0500, Eric Sandeen wrote:

...

diff --git a/include/xfs_da_format.h b/include/xfs_da_format.h
index 89a1a21..11f1420 100644
--- a/include/xfs_da_format.h
+++ b/include/xfs_da_format.h
@@ -561,7 +561,6 @@ xfs_dir3_dirent_get_ftype(
        if (xfs_sb_version_hasftype(&mp->m_sb)) {
                __uint8_t       type = dep->name[dep->namelen];

-               ASSERT(type < XFS_DIR3_FT_MAX);
                if (type < XFS_DIR3_FT_MAX)
                        return type;

Needs to be fixed kernel-side first.

xfs_dir3_dirent_get_ftype doesn't exist in kernelspace :)

bleah, why do they have different names...  Ok, will send.

-Eric
Cheers,

Dave.


<Prev in Thread] Current Thread [Next in Thread>