| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 5/9] xfs: xfs_bioerror can die. |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Fri, 29 Aug 2014 11:05:54 +1000 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140829002825.GE17502@xxxxxxxxxxxxx> |
| References: | <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-6-git-send-email-david@xxxxxxxxxxxxx> <20140829002825.GE17502@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
On Thu, Aug 28, 2014 at 05:28:25PM -0700, Christoph Hellwig wrote: > On Fri, Aug 15, 2014 at 04:39:03PM +1000, Dave Chinner wrote: > > Internal buffer write error handling is a mess due to the unnatural > > split between xfs_bioerror and xfs_bioerror_relse(). The buffer > > reference counting is also wrong for the xfs_bioerror path for > > xfs_bwrite - it uses sync IO and so xfs_buf_ioend will release a > > hold count that was never taken. > > Which seems to be cause by patch 1 in the series, and thus the > additional hold for the error case should be introduced there. will fix. -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [PATCH 2/4] xfs: combine xfs_dir_canenter into xfs_dir_createname, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 6/9] xfs: kill xfs_bioerror_relse, Dave Chinner |
| Previous by Thread: | Re: [PATCH 5/9] xfs: xfs_bioerror can die., Christoph Hellwig |
| Next by Thread: | [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |