xfs
[Top] [All Lists]

Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate fun

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 29 Aug 2014 10:55:43 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140829002209.GB17502@xxxxxxxxxxxxx>
References: <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-3-git-send-email-david@xxxxxxxxxxxxx> <20140829002209.GB17502@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Aug 28, 2014 at 05:22:09PM -0700, Christoph Hellwig wrote:
> >  STATIC void
> 
> needs the static removed as pointed out by Brian.
> > -   bool                    read = !!(bp->b_flags & XBF_READ);
> > +   bool            read = !!(bp->b_flags & XBF_READ);
> 
> We don't really need the double negation here.

Good point. I'll fix it.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>