| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/7] xfs: don't zero partial page cache pages during O_DIRECT writes |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 28 Aug 2014 17:39:51 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1409226551-16570-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1409226551-16570-1-git-send-email-david@xxxxxxxxxxxxx> <1409226551-16570-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 28, 2014 at 09:49:07PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Similar to direct IO reads, direct IO writes are using > truncate_pagecache_range to invalidate the page cache. This is > incorrect due to the sub-block zeroing in the page cache that > truncate_pagecache_range() triggers. > > This patch fixes things by using invalidate_inode_pages2_range > instead. It preserves the page cache invalidation, but won't zero > any pages. Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 2/7] xfs: don't zero partial page cache pages during O_DIRECT writes, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 4/7] xfs: use ranged writeback and invalidation for direct IO, Christoph Hellwig |
| Previous by Thread: | [PATCH 3/7] xfs: don't zero partial page cache pages during O_DIRECT writes, Dave Chinner |
| Next by Thread: | [PATCH 6/7] xfs: xfs_file_collapse_range is delalloc challenged, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |