| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/9] xfs: kill xfs_bdstrat_cb |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 28 Aug 2014 17:24:36 -0700 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1408084747-4540-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.23 (2014-03-12) |
On Fri, Aug 15, 2014 at 04:39:02PM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Only has two callers, and is just a shutdown check and error handler > around xfs_buf_iorequest. However, the error handling is a mess of > read and write semantics, and both internal callers only call it for > writes. Hence kill the wrapper, and follow up with a patch to > sanitise the error handling. > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx> |
| Previous by Date: | Re: [PATCH 3/9] xfs: rework xfs_buf_bio_endio error handling, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 5/9] xfs: xfs_bioerror can die., Christoph Hellwig |
| Previous by Thread: | [PATCH 4/9] xfs: kill xfs_bdstrat_cb, Dave Chinner |
| Next by Thread: | [PATCH 8/9] xfs: introduce xfs_buf_submit[_wait], Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |