xfs
[Top] [All Lists]

Re: [PATCH 3/9] xfs: rework xfs_buf_bio_endio error handling

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/9] xfs: rework xfs_buf_bio_endio error handling
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 Aug 2014 17:23:56 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1408084747-4540-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Fri, Aug 15, 2014 at 04:39:01PM +1000, Dave Chinner wrote:
> In doing so, allow xfs_buf_iorequest to return an error. That way,
> the caller can check for submission errors safely if required, and
> easily distinguish them from completion errors that come from
> xfs_buf_iowait().

While this looks correct to me it also looks confusing.  Why can't
we simply propagat the submission errors through error returns
and use ->b_error for completion errors instead?

<Prev in Thread] Current Thread [Next in Thread>