xfs
[Top] [All Lists]

Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate fun

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/9] xfs: xfs_buf_ioend and xfs_buf_iodone_work duplicate functionality
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 28 Aug 2014 17:22:09 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1408084747-4540-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
>  STATIC void

needs the static removed as pointed out by Brian.
> -     bool                    read = !!(bp->b_flags & XBF_READ);
> +     bool            read = !!(bp->b_flags & XBF_READ);

We don't really need the double negation here.

Otherwise this looks reasonable to me.

<Prev in Thread] Current Thread [Next in Thread>