xfs
[Top] [All Lists]

[RFC, PATCH 0/4] xfs: clean up xlog_recover_process_data

To: xfs@xxxxxxxxxxx
Subject: [RFC, PATCH 0/4] xfs: clean up xlog_recover_process_data
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 26 Aug 2014 11:21:37 +1000
Delivered-to: xfs@xxxxxxxxxxx
Hi folks,

The log recovery use-after-free that Brian posted a patch for has
had several previous attempts sent and none have completed review.
So let's put this one to bed for good.

This patch set addresses the previous review feedback for fixing
this problem. It factors xlog_recover_process_data() to make it
cleaner and isolate the context of the transaction recvoery
structure that is causing problems. It fixes a leak of the structure
in an error condition that I noticed while factoring, as well as the
double free that Brian and others have identified and tried to fix
in the past. It then re-arranges the recovery item management code
to put it all in one place, rather than in 3 separate parts of the
file separated by several hundred lines of unrelated code.

Comments?

-Dave.

<Prev in Thread] Current Thread [Next in Thread>