xfs
[Top] [All Lists]

Re: [PATCH] xfs: deduplicate xlog_do_recovery_pass()

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs: deduplicate xlog_do_recovery_pass()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 20 Aug 2014 23:36:40 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53F5651C.8030206@xxxxxxxxxx>
References: <53F5651C.8030206@xxxxxxxxxx>
On 8/20/14, 10:18 PM, Eric Sandeen wrote:
> In xlog_do_recovery_pass(), there are 2 distinct cases:
> non-wrapped and wrapped log recovery.
> 
> If we find a wrapped log, we recover around the end
> of the log, and then handle the rest of recovery
> exactly as in the non-wrapped case - using exactly the same
> (duplicated) code.
> 
> Rather than having the same code in both cases, we can
> get the wrapped portion out of the way first if needed,
> and then recover the non-wrapped portion of the log.
> 
> There should be no functional change here, just code
> reorganization & deduplication.
> 
> The patch looks a bit bigger than it really is; the last
> hunk is whitespace changes (un-indenting).
> 
> Tested with xfstests "check -g log" on a stock configuration.

which didn't actually hit any log wraps.  Does xfstests
really not cover wrapped log recovery?  anyway, something like this
on a small log:

[root@bp-05 xfstests]# while true; do mount /dev/sdc5 /mnt/scratch; 
ltp/fsstress -n 500 -d /mnt/scratch; src/godown -f /mnt/scratch; umount 
/mnt/scratch; done

hit plenty of log wraps w/ no problem.

-Eric

<Prev in Thread] Current Thread [Next in Thread>