xfs
[Top] [All Lists]

Re: [PATCH 9/9] xfs: check xfs_buf_read_uncached returns correctly

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/9] xfs: check xfs_buf_read_uncached returns correctly
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 16 Aug 2014 09:58:43 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140815125608.GA27856@xxxxxxxxxxxxx>
References: <1408084747-4540-1-git-send-email-david@xxxxxxxxxxxxx> <1408084747-4540-10-git-send-email-david@xxxxxxxxxxxxx> <20140815125608.GA27856@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Aug 15, 2014 at 05:56:08AM -0700, Christoph Hellwig wrote:
> On Fri, Aug 15, 2014 at 04:39:07PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > xfs_buf_read_uncached() has two failure modes. If can either return
> > NULL or bp->b_error != 0 depending on the type of failure, and not
> > all callers check for both. Fix it up.
> 
> I'd rather get rid of these annoying calling conventions.  Make it
> return and errno, and the bp in a pointer argument, with the bp
> never non-NULL in case of error.

Ok. I considered that, then just did the simple thing.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>