xfs
[Top] [All Lists]

Re: [PATCH] xfs: don't zero partial page cache pages during O_DIRECT

To: Chris Mason <clm@xxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: don't zero partial page cache pages during O_DIRECT
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 08 Aug 2014 22:19:10 -0500
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53E5885A.9090302@xxxxxx>
References: <53E4E03A.7050101@xxxxxx> <20140809003628.GE26465@dastard> <53E5885A.9090302@xxxxxx>
On 8/8/14, 9:32 PM, Chris Mason wrote:

>> Go on, call me a deranged monkey on some serious mind-controlling
>> substances. I don't care. :)

Insider / obscure quote achievement unlocked!
 
> The deranged part is invalidating pos -> -1 on a huge file because of a
> single 512b direct read.  But, if you mix O_DIRECT and buffered you get
> what the monkeys give you and like it.

Agreed, I really scratch my head at that one...

-Eric

<Prev in Thread] Current Thread [Next in Thread>