xfs
[Top] [All Lists]

[PATCH 3/6 V2] xfs: kill VN_DIRTY()

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: [PATCH 3/6 V2] xfs: kill VN_DIRTY()
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 4 Aug 2014 13:20:16 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140731171302.GA22173@xxxxxxxxxxxxx>
References: <1406791995-14723-1-git-send-email-david@xxxxxxxxxxxxx> <1406791995-14723-4-git-send-email-david@xxxxxxxxxxxxx> <20140731171302.GA22173@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
From: Dave Chinner <dchinner@xxxxxxxxxx>

Only one user and the use of a dirty page cache check is redundant,
so just get rid of it.

Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

---
 fs/xfs/xfs_inode.c | 2 +-
 fs/xfs/xfs_vnode.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 1a5e068..fea3c92 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1635,7 +1635,7 @@ xfs_release(
                truncated = xfs_iflags_test_and_clear(ip, XFS_ITRUNCATED);
                if (truncated) {
                        xfs_iflags_clear(ip, XFS_IDIRTY_RELEASE);
-                       if (VN_DIRTY(VFS_I(ip)) && ip->i_delayed_blks > 0) {
+                       if (ip->i_delayed_blks > 0) {
                                error = filemap_flush(VFS_I(ip)->i_mapping);
                                if (error)
                                        return error;
diff --git a/fs/xfs/xfs_vnode.h b/fs/xfs/xfs_vnode.h
index e8a7738..07b475a 100644
--- a/fs/xfs/xfs_vnode.h
+++ b/fs/xfs/xfs_vnode.h
@@ -39,8 +39,6 @@ struct attrlist_cursor_kern;
  */
 #define VN_MAPPED(vp)  mapping_mapped(vp->i_mapping)
 #define VN_CACHED(vp)  (vp->i_mapping->nrpages)
-#define VN_DIRTY(vp)   mapping_tagged(vp->i_mapping, \
-                                       PAGECACHE_TAG_DIRTY)
 
 
 #endif /* __XFS_VNODE_H__ */

<Prev in Thread] Current Thread [Next in Thread>