xfs
[Top] [All Lists]

[PATCH 4/6] libhandle: Fix handle leak in path_to_fshandle error paths

To: xfs@xxxxxxxxxxx
Subject: [PATCH 4/6] libhandle: Fix handle leak in path_to_fshandle error paths
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 1 Aug 2014 09:59:17 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1406905159-12415-1-git-send-email-sandeen@xxxxxxxxxx>
References: <1406905159-12415-1-git-send-email-sandeen@xxxxxxxxxx>
path_to_fshandle calls obj_to_handle, which potentially
allocates a handle, but the handle isn't freed on
a subsequent error path.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
 libhandle/handle.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/libhandle/handle.c b/libhandle/handle.c
index 9f81483..3c1395a 100644
--- a/libhandle/handle.c
+++ b/libhandle/handle.c
@@ -97,6 +97,7 @@ path_to_fshandle(
                /* new filesystem. add it to the cache */
                fdhp = malloc(sizeof(struct fdhash));
                if (fdhp == NULL) {
+                       free(*fshanp);
                        close(fd);
                        errno = ENOMEM;
                        return -1;
-- 
1.7.1

<Prev in Thread] Current Thread [Next in Thread>