| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 1/6] xfs_io: free fshandlep in parent_check() |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Fri, 1 Aug 2014 09:59:14 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1406905159-12415-1-git-send-email-sandeen@xxxxxxxxxx> |
| References: | <1406905159-12415-1-git-send-email-sandeen@xxxxxxxxxx> |
The allocated fshandle wasn't freed in either normal
exit or error paths.
Do this, and consolidate cleanup into an out: target.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
io/parent.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/io/parent.c b/io/parent.c
index ca989e9..56e126d 100644
--- a/io/parent.c
+++ b/io/parent.c
@@ -258,9 +258,8 @@ parent_check(void)
if (!bstatbuf || !parentbuf) {
fprintf(stderr, _("unable to allocate buffers: %s\n"),
strerror(errno));
- free(bstatbuf);
- free(parentbuf);
- return 1;
+ err_status = 1;
+ goto out;
}
if (do_bulkstat(parentbuf, &parentbuf_size, bstatbuf, fsfd, fshandlep)
!= 0)
@@ -272,8 +271,10 @@ parent_check(void)
printf(_("succeeded checking %llu inodes\n"),
(unsigned long long) inodes_checked);
+out:
free(bstatbuf);
free(parentbuf);
+ free(fshandlep);
return err_status;
}
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 4/6] libhandle: Fix handle leak in path_to_fshandle error paths, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 2/6] xfs_fsr: fix leaks & catch error in fsrfile(), Eric Sandeen |
| Previous by Thread: | Re: [PATCH 4/6] libhandle: Fix handle leak in path_to_fshandle error paths, Brian Foster |
| Next by Thread: | Re: [PATCH 1/6] xfs_io: free fshandlep in parent_check(), Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |