| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 3/6] xfs_fsr: free handlep in fsrfs |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Fri, 1 Aug 2014 09:59:16 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1406905159-12415-1-git-send-email-sandeen@xxxxxxxxxx> |
| References: | <1406905159-12415-1-git-send-email-sandeen@xxxxxxxxxx> |
We leaked the fshandlep in both error returns and
normal function exit.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
fsr/xfs_fsr.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index 752d2db..580604c 100644
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -702,6 +702,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange)
if ((fsfd = open(mntdir, O_RDONLY)) < 0) {
fsrprintf(_("unable to open: %s: %s\n"),
mntdir, strerror( errno ));
+ free(fshandlep);
return -1;
}
@@ -709,6 +710,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange)
fsrprintf(_("Skipping %s: could not get XFS geometry\n"),
mntdir);
close(fsfd);
+ free(fshandlep);
return -1;
}
@@ -774,6 +776,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange)
out0:
tmp_close(mntdir);
close(fsfd);
+ free(fshandlep);
return 0;
}
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 6/6] xfs_db: free flist on error in write_struct(), Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 4/6] libhandle: Fix handle leak in path_to_fshandle error paths, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 6/6] xfs_db: free flist on error in write_struct(), Brian Foster |
| Next by Thread: | Re: [PATCH 3/6] xfs_fsr: free handlep in fsrfs, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |