xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 1 Aug 2014 09:02:12 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140731171602.GF22173@xxxxxxxxxxxxx>
References: <1406787128-11897-1-git-send-email-david@xxxxxxxxxxxxx> <1406787128-11897-3-git-send-email-david@xxxxxxxxxxxxx> <20140731171602.GF22173@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 31, 2014 at 10:16:02AM -0700, Christoph Hellwig wrote:
> >  int
> > +xfs_swap_extent_flush(
> > +   struct xfs_inode        *ip)
> > +{
> > +   int     error;
> 
> nipick:  shouldn't the arguments and local variables align to the same
> level?

*nod*

> Also a local struct inode variable instead of using VFS_I(ip) 4 times
> would be nice.

Will fix.

> Otherwise looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Thanks.

-Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>