xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfs: flush both inodes in xfs_swap_extents
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Jul 2014 10:16:02 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1406787128-11897-3-git-send-email-david@xxxxxxxxxxxxx>
References: <1406787128-11897-1-git-send-email-david@xxxxxxxxxxxxx> <1406787128-11897-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
>  int
> +xfs_swap_extent_flush(
> +     struct xfs_inode        *ip)
> +{
> +     int     error;

nipick:  shouldn't the arguments and local variables align to the same
level?

Also a local struct inode variable instead of using VFS_I(ip) 4 times
would be nice.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>