xfs
[Top] [All Lists]

Re: [PATCH 6/6] xfs: kill xfs_vnode.h

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/6] xfs: kill xfs_vnode.h
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Jul 2014 10:14:25 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1406791995-14723-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1406791995-14723-1-git-send-email-david@xxxxxxxxxxxxx> <1406791995-14723-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Jul 31, 2014 at 05:33:15PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Move the IO flag definitions to xfs_inode.h and kill the header file
> as it is now empty.
> 
> Removing the xfs_vnode.h file showed up an implicit header include
> path:
>       xfs_linux.h -> xfs_vnode.h -> xfs_fs.h
> 
> And so every xfs header file has been inplicitly been including
> xfs_fs.h where it is needed or not. Hence the removal of xfs_vnode.h
> causes all sorts of build issues because BBTOB() and friends are no
> longer automatically included in the build. This also gets fixed.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <david@xxxxxxxxxxxxx>

Looks fine,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>