xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: kill VN_DIRTY()

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: kill VN_DIRTY()
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 31 Jul 2014 10:13:02 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1406791995-14723-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1406791995-14723-1-git-send-email-david@xxxxxxxxxxxxx> <1406791995-14723-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Thu, Jul 31, 2014 at 05:33:12PM +1000, Dave Chinner wrote:
> -                     if (VN_DIRTY(VFS_I(ip)) && ip->i_delayed_blks > 0) {
> +                     if (mapping_tagged(VFS_I(ip)->i_mapping,
> +                                        PAGECACHE_TAG_DIRTY) &&
> +                         ip->i_delayed_blks > 0) {
>                               error = filemap_flush(VFS_I(ip)->i_mapping);

I don't think there's even any point in keeping the mapping_tagged
check.  filemap_flush handles the case where nothing is to flush
internally, and no other callers others with things like this either.

<Prev in Thread] Current Thread [Next in Thread>