Re: [PATCH 3/6] xfs: kill VN_DIRTY()

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Jul 31, 2014 at 05:33:12PM +1000, Dave Chinner wrote:
> -                     if (VN_DIRTY(VFS_I(ip)) && ip->i_delayed_blks > 0) {
> +                     if (mapping_tagged(VFS_I(ip)->i_mapping,
> +                                        PAGECACHE_TAG_DIRTY) &&
> +                         ip->i_delayed_blks > 0) {
>                               error = filemap_flush(VFS_I(ip)->i_mapping);

I don't think there's even any point in keeping the mapping_tagged
check.  filemap_flush handles the case where nothing is to flush
internally, and no other callers others with things like this either.