xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfs: new case to test inode allocations in post-growfs d

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfs: new case to test inode allocations in post-growfs disk space
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 22 Jul 2014 10:23:22 +1000
Cc: Eryu Guan <eguan@xxxxxxxxxx>, Boris Ranto <branto@xxxxxxxxxx>, Eric Sandeen <esandeen@xxxxxxxxxx>, fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140721134638.GA45794@xxxxxxxxxxxxxxx>
References: <1405529554-31225-1-git-send-email-eguan@xxxxxxxxxx> <20140721134638.GA45794@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 21, 2014 at 09:46:38AM -0400, Brian Foster wrote:
> On Thu, Jul 17, 2014 at 12:52:33AM +0800, Eryu Guan wrote:
> > Make sure inodes can be allocated in new space added by xfs_growfs.
> > 
> > Regression test for
> > xfs: allow inode allocations in post-growfs disk space
....
> > +# Create files to consume free inodes in background
> > +(
> > +   i=0
> > +   while [ $i -lt 1000 ]; do
> > +           mkdir $SCRATCH_MNT/testdir_$i
> > +           create_file $SCRATCH_MNT/testdir_$i &
> > +           let i=$i+1
> > +   done
> > +) >/dev/null 2>&1 &
> > +
> > +# Grow fs at the same time, at least x4
> > +# doubling or tripling the size couldn't reproduce
> > +$XFS_GROWFS_PROG -D $((dblocks * 4)) $SCRATCH_MNT >>$seqres.full
> > +
> 
> Even though this is still relatively small based on what people probably
> typically test, we're still making assumptions about the size of the
> scratch device.

_require_fs_space $SCRATCH_MNT <size>

solves that problem. And in places we require 10GB of space, so a
few hundred MB isn't an issue.


-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>