xfs
[Top] [All Lists]

Re: [PATCH] xfstests: log running test to dmesg

To: Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: log running test to dmesg
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 17 Jul 2014 23:37:35 -0500
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <534EF81D.20205@xxxxxxxxxx>
References: <534EF81D.20205@xxxxxxxxxx>
On 4/16/14, 4:37 PM, Eric Sandeen wrote:
> We already log the running test to system logs via "logger"
> but viro pointed out that we can use /dev/kmsg to insert it
> into dmesg as well.  When looking at the serial console that
> could be pretty useful.
> 
> Thanks to viro for the test -w suggestion too.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

can we get this one in?  Dave asked for a generic helper, but
no test needs to print to kmsg, and nobody else uses LOGGER_PROG.

All we use either one for is logging the test run.

If somebody needs it for another purpose, it makes sense to add a
helper...

-Eric

> ---
> 
> diff --git a/check b/check
> index 268417c..09b2320 100755
> --- a/check
> +++ b/check
> @@ -457,6 +457,7 @@ do
>       $timestamp && echo -n " ["`date "+%T"`"]"
>       [ ! -x $seq ] && chmod u+x $seq # ensure we can run it
>       $LOGGER_PROG "run xfstest $seqnum"
> +     test -w /dev/kmsg && echo "run xfstest $seqnum" > /dev/kmsg
>       ./$seq >$tmp.rawout 2>&1
>       sts=$?
>       $timestamp && _timestamp
> 
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfstests: log running test to dmesg, Eric Sandeen <=