[Top] [All Lists]

Re: [PATCH] logprint: Fix printing of AGF buffers

To: Jan Kara <jack@xxxxxxx>
Subject: Re: [PATCH] logprint: Fix printing of AGF buffers
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 18 Jul 2014 10:29:31 +1000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140717083905.GB1649@xxxxxxxxxxxxx>
References: <1405349100-19734-1-git-send-email-jack@xxxxxxx> <20140715101931.GC30363@xxxxxxxxxxxxx> <20140715140938.GA1733@xxxxxxxxxxxxx> <20140715153922.GB5369@xxxxxxxxxxxxx> <20140716003851.GO22339@dastard> <20140716081105.GB29924@xxxxxxxxxxxxx> <20140716231725.GF4453@dastard> <20140717083905.GB1649@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 17, 2014 at 10:39:05AM +0200, Jan Kara wrote:
> On Thu 17-07-14 09:17:25, Dave Chinner wrote:
> > IOWs, we've played whack-a-mole on this again while ignoring the
> > fundamental issues ithat still remain:
> > 
> >     - that logprint has a lot of assumptions that simply aren't
> >       true; and
> >     - that logprint simply does not handle split region
> >       continuations like the kernel recovery code does.
> > 
> > Both of these things lead to having to handle these strange "out of
> > space" cases in multiple places, and simply not handling them in
> > places that actually need to.
> > 
> > These are just more reasons why logprint - as it says itself in a
> > couple of comments - needs a complete rewrite.
>   Yeah, I've noticed that logprint definitely doesn't handle all possible
> cases and the code is ... well, organic :).

That's a very polite way of putting it ;)

> OTOH it worked for me (except
> for this bug) when I needed so for a debug tool like that it seemed good
> enough. I don't feel like rewriting it from scratch (at least in near
> future) but if someone can find time for that, it would be surely welcome.

Right, that's effectively been the state of play for some time. It's
a useful tool that could do with some work to make it better, but
nobody has had the time to do that work because most of the time it
works fine...

If only there were some minions around looking to learn about XFS
log recovery....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>