[Top] [All Lists]

Re: xfsrestore -t and default location of housekeeping dir

To: xfs@xxxxxxxxxxx
Subject: Re: xfsrestore -t and default location of housekeeping dir
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 17 Jul 2014 02:05:50 -0700
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140714071935.GB29541@xxxxxxxxxxxxxxxxx>
References: <20140714071935.GB29541@xxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Mon, Jul 14, 2014 at 09:19:35AM +0200, Iustin Pop wrote:
> Hi,
> While testing a just-made dump with via 'xfsrestore -t', I learned that
> the default housekeepingdir path is still under the original filesystem.
> My xfsrestore therefore failed, since that filesystem was read-only.
> Since '-t' should denote a pure no-op operation, with no changes, would
> it make more sense to default the housekeeping location to a temporary
> location if it is used?

It seems to me like -t shouldn't recreate the files in the housekeeping
directory at all.  I did take a brief look at the code and is a huge
mess that seems to recreate files unconditionally, so I don't really
have a good solution for this yet.

<Prev in Thread] Current Thread [Next in Thread>