[Top] [All Lists]

Re: v0.80.4 Firefly released

To: Gregory Farnum <gregory.farnum@xxxxxxxxxxxxx>
Subject: Re: v0.80.4 Firefly released
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 17 Jul 2014 08:31:50 +1000
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Samuel Just <sam.just@xxxxxxxxxxx>, "ceph-devel@xxxxxxxxxxxxxxx" <ceph-devel@xxxxxxxxxxxxxxx>, Sage Weil <sage@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CAPYLRziqpnjHbViaFw2MtXcYKiCDE9wz8qaqiQjAJGDoUbG7cg@xxxxxxxxxxxxxx>
References: <alpine.DEB.2.00.1407151634250.21336@xxxxxxxxxxxxxxxxxx> <20140716092226.GA23561@xxxxxxxxxxxxx> <CAPYLRziqpnjHbViaFw2MtXcYKiCDE9wz8qaqiQjAJGDoUbG7cg@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 16, 2014 at 10:26:23AM -0700, Gregory Farnum wrote:
> On Wed, Jul 16, 2014 at 2:22 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> > On Tue, Jul 15, 2014 at 04:45:59PM -0700, Sage Weil wrote:
> >> This Firefly point release fixes an potential data corruption problem
> >> when ceph-osd daemons run on top of XFS and service Firefly librbd
> >> clients.  A recently added allocation hint that RBD utilizes triggers
> >> an XFS bug on some kernels (Linux 3.2, and likely others) that leads
> >> to data corruption and deep-scrub errors (and inconsistent PGs).  This
> >> release avoids the situation by disabling the allocation hint until we
> >> can validate which kernels are affected and/or are known to be safe to
> >> use the hint on.
> >
> > I've not really seen an report for that on the XFS list, could it be
> > that you're running into the issue fixed by
> >
> >  "xfs: Use preallocation for inodes with extsz hints"
> >
> > (commit aff3a9edb7080f69f07fe76a8bd089b3dfa4cb5d)?
> Sam reported the issue we're seeing in "consequences of
> XFS_IOC_FSSETXATTR on non-empty file?",

Assuming you've created an extent size hint with a file with delayed
allocation on it and no blocks, then that's more than likely the
same issue. The above commit uses preallocation to allocate
unwritten extents rather than delayed allocation for files with
extent size hints because delayed allocation doesn't write zeros
over ranges in the allocated extents that don't have dirty data over

Moral of the story: any time you get what appears to be data
corruption in the underlying data store, you should report it to the
relevant filesystem list rather than try to work around it....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>