xfs
[Top] [All Lists]

Re: [PATCH] logprint: Fix printing of AGF buffers

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] logprint: Fix printing of AGF buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Jul 2014 01:11:05 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140716003851.GO22339@dastard>
References: <1405349100-19734-1-git-send-email-jack@xxxxxxx> <20140715101931.GC30363@xxxxxxxxxxxxx> <20140715140938.GA1733@xxxxxxxxxxxxx> <20140715153922.GB5369@xxxxxxxxxxxxx> <20140716003851.GO22339@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Jul 16, 2014 at 10:38:51AM +1000, Dave Chinner wrote:
> I added this:
> 
>       /*
>        * The addition of spare space and the non-logged CRC format
>        * fields to the AGF mean that the size that is logged is almost
>        * always going to be smaller than the structure itself. Hence
>        * we need to make sure that the buffer contains all the data we
>        * want to print rather than just check against the structure
>        * size.
>        */
> 
> Cheers,

I'd prefer to mention v4 filesystems as well:

        /*
         * v4 filesystems only contain the fields before the uuid, and
         * even v5 filesystems don't usually log any field beneath it.
         */

note that the AGI case also needs the same treatment.

<Prev in Thread] Current Thread [Next in Thread>