[Top] [All Lists]

Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 16 Jul 2014 00:12:50 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53C62595.6010702@xxxxxxxxxx>
References: <53C4F5DB.2060108@xxxxxxxxxx> <20140715102520.GH30363@xxxxxxxxxxxxx> <53C62595.6010702@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Jul 16, 2014 at 03:11:17PM +0800, Jeff Liu wrote:
> > This code was introduced by commit
> > 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the
> > broken quotarm code.  Seems like we need a testcase for this
> > functionality or just remove it.  Physically removing the quota file
> > never seems that useful to me to start with..
> Is there an approach to verify that a particular quota file inode has
> been successfully removed?  It seems we have to do this in a test case
> but am not yet figure out a way, or any thoughts for the test case?

umount the filesystem and check that the field in the superblock
pointing to that kind of quota inode is zeroed out would be my

<Prev in Thread] Current Thread [Next in Thread>