| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota |
| From: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
| Date: | Wed, 16 Jul 2014 15:11:17 +0800 |
| Cc: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140715102520.GH30363@xxxxxxxxxxxxx> |
| References: | <53C4F5DB.2060108@xxxxxxxxxx> <20140715102520.GH30363@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 07/15/2014 18:25 PM, Christoph Hellwig wrote: > On Tue, Jul 15, 2014 at 05:35:23PM +0800, Jeff Liu wrote: >> From: Jie Liu <jeff.liu@xxxxxxxxxx> >> >> We are intended to check up uflags against FS_PROJ_QUOTA rather than >> FS_USER_UQUOTA once more, it looks to me like a typo, but might cause >> the project quota metadata space can not be removed. > > This code was introduced by commit > 9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the > broken quotarm code. Seems like we need a testcase for this > functionality or just remove it. Physically removing the quota file > never seems that useful to me to start with.. Is there an approach to verify that a particular quota file inode has been successfully removed? It seems we have to do this in a test case but am not yet figure out a way, or any thoughts for the test case? Cheers, -Jeff |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: time for an xfsdump release?, Nathan Scott |
|---|---|
| Next by Date: | Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |