[Top] [All Lists]

Re: [PATCH] Detect strto* failures based on errno.

To: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH] Detect strto* failures based on errno.
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 16 Jul 2014 13:01:32 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1405324619-25515-1-git-send-email-arekm@xxxxxxxx>
References: <20140713230406.GE22339@dastard> <1405324619-25515-1-git-send-email-arekm@xxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 14, 2014 at 09:56:59AM +0200, Arkadiusz MiÅkiewicz wrote:
> Code was testing for ERANGE errno only in some places. In other places
> it didn't do any errno checking at all.
> Unify strto* result testing by treating any non zero errno as failure.
> Signed-off-by: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>

This patch appears to cause xfs/071 to fail:

     Writing 512 bytes, offset is +0 (direct=false)
    -pwrite64: File too large
    +non-numeric offset argument -- <OFFSET>
     Reading 512 bytes (direct=false)
     read 0/512 bytes at offset <OFFSET>
    (Run 'diff -u tests/xfs/071.out 
/home/dave/src/xfstests-dev/results//xfs/071.out.bad'  to see the entire diff)

Can you have a look into this?


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>