Re: [PATCH] Detect strto* failures based on errno.

xfs

Re: [PATCH] Detect strto* failures based on errno.

To:	Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>
Subject:	Re: [PATCH] Detect strto* failures based on errno.
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 16 Jul 2014 10:00:49 +1000
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1405324619-25515-1-git-send-email-arekm@xxxxxxxx>
References:	<20140713230406.GE22339@dastard> <1405324619-25515-1-git-send-email-arekm@xxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

On Mon, Jul 14, 2014 at 09:56:59AM +0200, Arkadiusz MiÅkiewicz wrote:
> Code was testing for ERANGE errno only in some places. In other places
> it didn't do any errno checking at all.
> 
> Unify strto* result testing by treating any non zero errno as failure.
> 
> Signed-off-by: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>

Arkadiusz, why did git-send-email encode this entire commit in
base64? Can you configure git to send patches in plain text? even
UTF-8 encoding is fine.

Yes, I know git am handles base64 encoded emails, but humans
don't.... :/

As it is, the patch is fine.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] Catch under/overflow cases in cvtnum() and cvttime()., Arkadiusz MiÅkiewicz Re: [PATCH] Catch under/overflow cases in cvtnum() and cvttime()., Eric Sandeen Re: [PATCH] Catch under/overflow cases in cvtnum() and cvttime()., Arkadiusz MiÅkiewicz Re: [PATCH] Catch under/overflow cases in cvtnum() and cvttime()., Eric Sandeen Re: [PATCH] Catch under/overflow cases in cvtnum() and cvttime()., Eric Sandeen *[PATCH] Init errno before strto calls.*, Arkadiusz MiÅkiewicz* *Re: [PATCH] Init errno before strto calls.*, Dave Chinner* *[PATCH] Detect strto failures based on errno.*, Arkadiusz MiÅkiewicz* *Re: [PATCH] Detect strto failures based on errno.*, Dave Chinner* <= *Re: [PATCH] Detect strto failures based on errno.*, Dave Chinner* *Re: [PATCH] Detect strto failures based on errno.*, Arkadiusz MiÅkiewicz* *Re: [PATCH] Detect strto failures based on errno.*, Dave Chinner*

Previous by Date:	Re: symlink loop for /lib64/libhandle.so, Christoph Hellwig
Next by Date:	Re: [PATCH] logprint: Fix printing of AGF buffers, Dave Chinner
Previous by Thread:	*[PATCH] Detect strto failures based on errno.*, Arkadiusz MiÅkiewicz*
Next by Thread:	*Re: [PATCH] Detect strto failures based on errno.*, Dave Chinner*
Indexes:	[Date] [Thread] [Top] [All Lists]