xfs
[Top] [All Lists]

[PATCH] xfs: fix rounding error of fiemap length parameter

To: xfs@xxxxxxxxxxx
Subject: [PATCH] xfs: fix rounding error of fiemap length parameter
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Tue, 15 Jul 2014 11:08:06 -0400
Cc: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
The offset and length parameters are converted from bytes to basic
blocks by xfs_vn_fiemap(). The BTOBB() converter rounds the value up to
the nearest basic block. This leads to unexpected behavior when
unaligned offsets are provided to FIEMAP.

Fix the conversions of byte values to block values to cover the provided
offsets. Round down the start offset to the nearest basic block.
Calculate the end offset based on the provided values, round up and
calculate length based on the start block offset.

Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
Reported-by: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx>
---

Here's another pass at this. I think this is consistent with what ext4
does...

Brian

 fs/xfs/xfs_iops.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index d75621a..7212949 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -1055,12 +1055,12 @@ xfs_vn_fiemap(
                return error;
 
        /* Set up bmap header for xfs internal routine */
-       bm.bmv_offset = BTOBB(start);
+       bm.bmv_offset = BTOBBT(start);
        /* Special case for whole file */
        if (length == FIEMAP_MAX_OFFSET)
                bm.bmv_length = -1LL;
        else
-               bm.bmv_length = BTOBB(length);
+               bm.bmv_length = BTOBB(start + length) - bm.bmv_offset;
 
        /* We add one because in getbmap world count includes the header */
        bm.bmv_count = !fieinfo->fi_extents_max ? MAXEXTNUM :
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] xfs: fix rounding error of fiemap length parameter, Brian Foster <=