xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs/quota: fix NULL pointer dereference in report_f
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 15 Jul 2014 07:54:06 -0500
Cc: Jeff Liu <jeff.liu@xxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140715101437.GB30363@xxxxxxxxxxxxx>
References: <52849CC5.10109@xxxxxxxxxx> <53C091E1.1010907@xxxxxxxxxxx> <20140715101437.GB30363@xxxxxxxxxxxxx>
On 7/15/14, 5:14 AM, Christoph Hellwig wrote:
> On Fri, Jul 11, 2014 at 08:39:45PM -0500, Eric Sandeen wrote:
>>> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
>>
>> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>>
>> I know hch had grand plans to make this all nicer, but based on Jeff's
>> followup emails, it looks like this is the only spot needed to simply
>> resolve the problems w/ nonexistent paths in quota, and is a small,
>> contained change we can easily make before the next point release.
> 
> Didn't I say I'm fine with putting this in earlier even if I'd prefer
> a grand solution?

Yes, you did, but it never got a formal reviewed-by or got merged, so I bumped 
it :)


FWIW I did look at the grand solution, and there was .. something that
didn't make sense to me, so I backed off.  Oh, yeah, I wasn't quite
sure what to do with:

add_args_command(init_args_command);
and
init_args_command();

in quota/init.c  

-Eric



> either way, consider this:
> 
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 

<Prev in Thread] Current Thread [Next in Thread>