xfs
[Top] [All Lists]

Re: symlink loop for /lib64/libhandle.so

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: symlink loop for /lib64/libhandle.so
From: Jan ÅulÃk <jan@xxxxxxxx>
Date: Tue, 15 Jul 2014 12:28:26 +0200
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Brian Foster <bfoster@xxxxxxxxxx>, XFS mail list <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140714082607.GA19882@xxxxxxxxxxxxx>
References: <1404898212.7231.12.camel@jtulak> <20140709132836.GA65226@xxxxxxxxxxxxxxx> <20140710134851.GA26652@xxxxxxxxxxxxx> <1405009872.31068.22.camel@jtulak> <53BEC1E7.1070904@xxxxxxxxxxx> <1405075678.28203.56.camel@jtulak> <1405325087.3196.6.camel@jtulak> <20140714082607.GA19882@xxxxxxxxxxxxx>
2014-07-14 10:26 GMT+02:00 Christoph Hellwig <hch@xxxxxxxxxxxxx>:
>
> Can you just send the properly formatted and signed off patch to the
> list?  That's the usual process for XFS changes and makes everyones life
> simpler.
>

I hope this is all right.
And sorry Chris, I mistakenly replied just to you instead of into the
mailing list.


Reported-by: Jan Tulak <jan at tulak.me>
Signed-off-by: Jan Tulak <jan at tulak.me>
---
include/buildmacros | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/include/buildmacros b/include/buildmacros
index 7a01880..657b82a 100644
--- a/include/buildmacros
+++ b/include/buildmacros
@@ -76,7 +76,11 @@ INSTALL_LTLIB_DEV = \
        ../$(INSTALL) -m 644 $(LIBNAME).lai $(PKG_LIB_DIR)/$(LIBNAME).la ; \
        ../$(INSTALL) -m 755 -d $(PKG_ROOT_LIB_DIR); \
        ../$(INSTALL) -T so_base $(LIBNAME).lai $(PKG_ROOT_LIB_DIR); \
-       if test "x$(PKG_LIB_DIR)" != "x$(PKG_ROOT_LIB_DIR)" ; then \
+       if test "x$(PKG_LIB_DIR)" != "x$(PKG_ROOT_LIB_DIR)"\
+       -a "x$(shell readlink -f $(PKG_ROOT_LIB_DIR))" != "x$(PKG_LIB_DIR)"\
+       -a "x$(shell readlink -f $(PKG_LIB_DIR))" != "x$(PKG_ROOT_LIB_DIR)"\
+       -a "x$(shell readlink -f $(PKG_LIB_DIR))" != "x$(shell
readlink -f $(PKG_ROOT_LIB_DIR))";\
+       then \
        ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).a
$(PKG_ROOT_LIB_DIR)/$(LIBNAME)
.a; \
        ../$(INSTALL) -S $(PKG_LIB_DIR)/$(LIBNAME).la
$(PKG_ROOT_LIB_DIR)/$(LIBNAME).la; \
        ../$(INSTALL) -S $(PKG_ROOT_LIB_DIR)/$(LIBNAME).so
$(PKG_LIB_DIR)/$(LIBNAME).so; \

2014-07-14 10:26 GMT+02:00 Christoph Hellwig <hch@xxxxxxxxxxxxx>:
> On Mon, Jul 14, 2014 at 10:04:47AM +0200, Jan ??ul??k wrote:
>> And I have created a bug report and added the proposed change as a
>> patch: http://oss.sgi.com/bugzilla/show_bug.cgi?id=1059
>
> Can you just send the properly formatted and signed off patch to the
> list?  That's the usual process for XFS changes and makes everyones life
> simpler.
>

<Prev in Thread] Current Thread [Next in Thread>