xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota

To: Jeff Liu <jeff.liu@xxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix uflags detection at xfs_fs_rm_xquota
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 03:25:20 -0700
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53C4F5DB.2060108@xxxxxxxxxx>
References: <53C4F5DB.2060108@xxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Tue, Jul 15, 2014 at 05:35:23PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> We are intended to check up uflags against FS_PROJ_QUOTA rather than 
> FS_USER_UQUOTA once more, it looks to me like a typo, but might cause
> the project quota metadata space can not be removed.

This code was introduced by commit
9da93f9b7cdf8ab28da6b364cdc1fafc8670b4dc which attempts to fix the
broken quotarm code.  Seems like we need a testcase for this
functionality or just remove it.  Physically removing the quota file
never seems that useful to me to start with..

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>