[Top] [All Lists]

Re: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl

To: Theodore Ts'o <tytso@xxxxxxx>, Dmitry Monakhov <dmonakhov@xxxxxxxxxx>, Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, 'Christoph Hellwig' <hch@xxxxxxxxxxxxx>, 'linux-ext4' <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 'Luk?? Czerner' <lczerner@xxxxxxxxxx>, 'Brian Foster' <bfoster@xxxxxxxxxx>, 'Ashish Sangwan' <a.sangwan@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 08:06:33 +1000
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140714212539.GH8935@xxxxxxxxx>
References: <003f01cf9aa4$1e9e5240$5bdaf6c0$@samsung.com> <20140708121500.GA518@xxxxxxxxxxxxx> <001801cf9b3f$ad786ff0$08694fd0$@samsung.com> <87ha2jsy6p.fsf@xxxxxxxxxx> <20140714212539.GH8935@xxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 14, 2014 at 05:25:39PM -0400, Theodore Ts'o wrote:
> On Mon, Jul 14, 2014 at 08:27:26PM +0400, Dmitry Monakhov wrote:
> > Actually they are differ. EXT4_IOC_MOVE_EXT copy data inside kernel,
> > but XFS_IOC_SWAPEXT live this job to userpsace see:
> > http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfsprogs.git;a=blob;f=fsr/xfs_fsr.c
> >  packfile
> > And I'll vote to make EXT4_IOC_MOVE_EXT deprecated, and implement 
> > as XFS does that.
> > Ted, Lukas what do you think about that?
> The reason why EXT4_IOC_MOVE_EXT moves the data via the cache is to
> avoid being subject to races if the file happens to mmap'ed and being
> actively modified at the time of the defrag operation.  
> I'm not sure how XFS handles that case, but if it's not somehow
> locking the file against mmap's before it starts the userspace copy,
> it would seem to me to be fairly dangerous in terms of prevent
> potential data loss in this scenario.  Unless they are doing some
> especially clever?

Yes, we're being clever:

        a) we can snapshot the inode directly with bulkstat and then
        feed that as a cookie back into the swap extent ioctl, hence
        detect any change made to the inode since the snapshot was

        b) we do invisible IO to copy the data (i.e. doesn't update
        timestamps on the files); and

        c) the swap ext ioctl aborts if the file is mmapped() at the
        time we do the extent swap.

Basically, if there is any inconsistency or trouble, we abort the
swap without doing anything and leave userspace to clean up.

As it is, we'll be looking to replace the swapext call with this new
move ioctl because we can do a lot more with it and avoids
implementation wrinkles like having to check and handle different
sized data and inode forks, and having to change the owner field in
every bmap btree block after the swap has occurred.

FWIW, what we ideally need for these sorts of defrag programs is
per-file freezing. i.e. we freeze the file to be defragged, then do
the copy in userspace, swap/move the copied range and then unfreeze
it once complete.  That guarantees that the file is not modified in
any way while userspace is doing the defrag...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>