xfs
[Top] [All Lists]

Re: consequences of XFS_IOC_FSSETXATTR on non-empty file?

To: Ilya Dryomov <ilya.dryomov@xxxxxxxxxxx>
Subject: Re: consequences of XFS_IOC_FSSETXATTR on non-empty file?
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 15 Jul 2014 06:23:31 +1000
Cc: Samuel Just <sam.just@xxxxxxxxxxx>, xfs@xxxxxxxxxxx, "ceph-devel@xxxxxxxxxxxxxxx" <ceph-devel@xxxxxxxxxxxxxxx>, Sage Weil <sage@xxxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <CALFYKtBVLLTjXnxS3qc7sCYbc+MfFFrGsbM1D_8jK4oiUd267w@xxxxxxxxxxxxxx>
References: <CA+4uBUYg+81G2=sj3qXO4GGgA7pyjgVrGDCN+UQ32jnWgSbG5w@xxxxxxxxxxxxxx> <20140713012624.GS4453@dastard> <CA+4uBUZwuh5t28jU5jfQb3ApdUKx8t88hg6m8CXS+0ztpi6OTw@xxxxxxxxxxxxxx> <CALFYKtC7J1ZvW40wsSWmVpNS5T3tmAOmY9CP=nsh4r=iUjeznA@xxxxxxxxxxxxxx> <20140713225532.GD22339@dastard> <CALFYKtBVLLTjXnxS3qc7sCYbc+MfFFrGsbM1D_8jK4oiUd267w@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Jul 14, 2014 at 11:24:05AM +0400, Ilya Dryomov wrote:
> On Mon, Jul 14, 2014 at 2:55 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > On Sun, Jul 13, 2014 at 09:01:13PM +0400, Ilya Dryomov wrote:
> >> On Sun, Jul 13, 2014 at 5:48 AM, Samuel Just <sam.just@xxxxxxxxxxx> wrote:
> >> I think if you call fsync() or even
> >> fdatasync() before close(fd), it will fail as expected.
> >
> > Only if you are trying to change the extent size immediately after
> > the first write you do to an empty file. Which is, as per the above,
> > not the recommended or intended use of the ioctl.
> 
> That's understood, but that is exactly what Sam's test program happens
> to try to do, so I had to point the "file w/o real extents" thing out.

Oh, I missed that there was a test program attached. That's what
happens when people top post a reply then attach text at the
bottom....

Moral of the story: don't top post ;)

Cheersm

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>