xfs
[Top] [All Lists]

RE: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl

To: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>, 'Christoph Hellwig' <hch@xxxxxxxxxxxxx>
Subject: RE: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl
From: Dmitry Monakhov <dmonakhov@xxxxxxxxxx>
Date: Mon, 14 Jul 2014 20:27:26 +0400
Cc: 'Dave Chinner' <david@xxxxxxxxxxxxx>, 'Theodore Ts'o' <tytso@xxxxxxx>, 'linux-ext4' <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 'Luk?? Czerner' <lczerner@xxxxxxxxxx>, 'Brian Foster' <bfoster@xxxxxxxxxx>, 'Ashish Sangwan' <a.sangwan@xxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=3hOrs/BNrBo0hzK7spe6F8uGthgljT5aL7gE7QFjerU=; b=O/6BuJ6/qeUOzeD8RvNJkGs0jA4/3L/+PWE6o3vz4jGuvg0G9HWj6aM1T2uZpikhAi AoZ6iqNTJK73J7lOdqJh/W+xVSbNMYmAskGOgz1zIzqM4hJq6g0WNbV1rRzAZ6B7S+kU Mw/1rHF150sr7LFI3L/r1ZR2jjuGFObZB+sj8LFUi77mSV6LBxgD39kkD8xmgzpvsq/P hDnJ+i3wvoMqVR9Q4wzhX3h/+Lh5y8NpycWx1OKmwo6ePukGsqQ8ElRiP7BSuTe1Djed d48PC7YQYROd2/4wjskpCRoZhFwQBKPzQZ4jBBeH8IQYkfJIyrcriwmF68GtDAN/8vBu fUHg==
In-reply-to: <001801cf9b3f$ad786ff0$08694fd0$@samsung.com>
References: <003f01cf9aa4$1e9e5240$5bdaf6c0$@samsung.com> <20140708121500.GA518@xxxxxxxxxxxxx> <001801cf9b3f$ad786ff0$08694fd0$@samsung.com>
Sender: Dmitry Monakhov <rjevskiy@xxxxxxxxx>
User-agent: Notmuch/0.6.1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-redhat-linux-gnu)
On Wed, 09 Jul 2014 15:33:21 +0900, Namjae Jeon <namjae.jeon@xxxxxxxxxxx> wrote:
> > 
> > On Tue, Jul 08, 2014 at 08:59:49PM +0900, Namjae Jeon wrote:
> > > This patch implements fs ioctl's IOC_MOV_DATA for XFS.
> > 
> > Shouldn't this share code with the XFS_IOC_SWAPEXT implementation?
> Lukas has raised the same question for ext4.
> Both xfs(XFS_IOC_SWAPEXT) and ext4(EXT4_IOC_MOVE_EXT) has ioctls which uses
> almost similar kind of structure as struct mov_data.
> As such, there seems to be possiblity for sharing basic code (I will try)
> used for sanity checking in IOC_MOV_DATA to be shared with these ioctls
> but the core functionality code will remain different.
> 
> Thanks!
Actually they are differ. EXT4_IOC_MOVE_EXT copy data inside kernel,
but XFS_IOC_SWAPEXT live this job to userpsace see:
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/cmds/xfsprogs.git;a=blob;f=fsr/xfs_fsr.c
 packfile
And I'll vote to make EXT4_IOC_MOVE_EXT deprecated, and implement 
EXT4_IOC_SWAPEXT
as XFS does that.
Ted, Lukas what do you think about that?

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

<Prev in Thread] Current Thread [Next in Thread>