xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when nee

To: LukÃÅ Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when needed
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 11 Jul 2014 06:50:11 +1000
Cc: fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <alpine.LFD.2.00.1407101031150.2659@xxxxxxxxxxxxxxxxxxxxx>
References: <1403617014-17870-1-git-send-email-lczerner@xxxxxxxxxx> <1403617014-17870-2-git-send-email-lczerner@xxxxxxxxxx> <20140710010711.GJ4453@dastard> <alpine.LFD.2.00.1407101031150.2659@xxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jul 10, 2014 at 10:38:45AM +0200, LukÃÅ Czerner wrote:
> On Thu, 10 Jul 2014, Dave Chinner wrote:
> I like the idea Eric proposed with the _require_test check for the
> test that actually require test device and then actually check the
> device only after such test. Will that be acceptable ? If so I'll
> rework the patches.

Works for me. Don't forget to add it to the "new" script as well
so the default is to check the test device. That will trigger us to
check if it is necessary during test development review, rather than
forgetting we need to add it. ;)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>