xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when nee

To: Dave Chinner <david@xxxxxxxxxxxxx>, Lukas Czerner <lczerner@xxxxxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: Check fs consistency on TEST_DEV only when needed
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 09 Jul 2014 20:52:18 -0500
Cc: fstests@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140710010711.GJ4453@dastard>
References: <1403617014-17870-1-git-send-email-lczerner@xxxxxxxxxx> <1403617014-17870-2-git-send-email-lczerner@xxxxxxxxxx> <20140710010711.GJ4453@dastard>
On 7/9/14, 8:07 PM, Dave Chinner wrote:
> Reducing runtime of the test harness is a good idea, but we should
> not do that if the cost is that it reduces the reliability of error
> detection.

Still, this could have a really big impact, especially on filesystems
with slow fsck.

It'd be great to find a way to make this reliable.

It's kind of a historical accident that "test" is always mounted, but
"scratch" must be _required.  What if we added _require_test if we're 
going to write to test, and doing so triggers the check?

I'm sure there are other ways around it.  Spending tons of time in fsck
for a filesystem we didn't touch isn't time well spent, IMHO.

-Eric

<Prev in Thread] Current Thread [Next in Thread>