xfs
[Top] [All Lists]

Re: [PATCH 1/2] libxfs: clear the buffer error while the buffer is locke

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] libxfs: clear the buffer error while the buffer is locked
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 9 Jul 2014 01:59:13 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1404862900-3369-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1404862900-3369-1-git-send-email-david@xxxxxxxxxxxxx> <1404862900-3369-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.23 (2014-03-12)
On Wed, Jul 09, 2014 at 09:41:39AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> When releasing a buffer, the error shoul dbe cleared while the lock
> is still held on the buffer to avoid racing with a new user of the
> buffer.
> 
> This was pointed out in review of commit 6af7c1e ("libxfs: reused
> invalidated buffers leak state and data") but the version committed
> didn't have the fix. Thanks to Christoph Hellwig for checking and
> pointing out the oversight.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>