| To: | 'Christoph Hellwig' <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | RE: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl |
| From: | Namjae Jeon <namjae.jeon@xxxxxxxxxxx> |
| Date: | Wed, 09 Jul 2014 15:33:21 +0900 |
| Cc: | 'Dave Chinner' <david@xxxxxxxxxxxxx>, 'Theodore Ts'o' <tytso@xxxxxxx>, 'linux-ext4' <linux-ext4@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, 'Luk?? Czerner' <lczerner@xxxxxxxxxx>, 'Brian Foster' <bfoster@xxxxxxxxxx>, 'Ashish Sangwan' <a.sangwan@xxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dlp-filter: | Pass |
| In-reply-to: | <20140708121500.GA518@xxxxxxxxxxxxx> |
| References: | <003f01cf9aa4$1e9e5240$5bdaf6c0$@samsung.com> <20140708121500.GA518@xxxxxxxxxxxxx> |
| Thread-index: | AQJH64km/LFjhKi9hcuiYREqQxtdmwKGaWSgmpJZKsA= |
> > On Tue, Jul 08, 2014 at 08:59:49PM +0900, Namjae Jeon wrote: > > This patch implements fs ioctl's IOC_MOV_DATA for XFS. > > Shouldn't this share code with the XFS_IOC_SWAPEXT implementation? Lukas has raised the same question for ext4. Both xfs(XFS_IOC_SWAPEXT) and ext4(EXT4_IOC_MOVE_EXT) has ioctls which uses almost similar kind of structure as struct mov_data. As such, there seems to be possiblity for sharing basic code (I will try) used for sanity checking in IOC_MOV_DATA to be shared with these ioctls but the core functionality code will remain different. Thanks! |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: usrquota, prjquota mount success on 3.16rc4 but Failed to initialize disk quotas on 3.10.43, Dave Chinner |
|---|---|
| Next by Date: | RE: [PATCH 3/3] ext4: Add support IOC_MOV_DATA ioctl, Namjae Jeon |
| Previous by Thread: | Re: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl, Christoph Hellwig |
| Next by Thread: | RE: [PATCH 2/3] xfs: Add support IOC_MOV_DATA ioctl, Dmitry Monakhov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |