xfs
[Top] [All Lists]

Re: [PATCH 4/6] libxfs: reused invalidated buffers leak state and data

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] libxfs: reused invalidated buffers leak state and data
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 7 Jul 2014 09:54:44 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140705094807.GB18130@xxxxxxxxxxxxx>
References: <1404453435-1915-1-git-send-email-david@xxxxxxxxxxxxx> <1404453435-1915-5-git-send-email-david@xxxxxxxxxxxxx> <20140704141509.GB29520@xxxxxxxxxxxxx> <20140704222210.GM9508@dastard> <20140705094807.GB18130@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Jul 05, 2014 at 02:48:07AM -0700, Christoph Hellwig wrote:
> On Sat, Jul 05, 2014 at 08:22:10AM +1000, Dave Chinner wrote:
> > I'm open to other ways of fixing this, but right now we've got to
> > fix xfs_repair because it's currently breaking filesystems worse
> > than before xfs_repair was run...
> 
> Ok, so clearly mark this as difference from kernel code in a long
> comment explaining the situation similar to wrote you above. 

Will do.

> It's
> pretty obvious that the buffer cache in userspace will eventually need
> a major overhaul sooner or later.  I wonder how feasible porting the
> kernel one would be..

It's not so much the porting that's the issue - it's cleaning up all
the applications that use it that is the headache. And,
realistically, I don't think there's much of the kernel code that
can be used - we have to rewrite all the allocation, freeing,
locking and IO parts of it, so we'd pretty much be re-implementing
most of it, anyway....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>