xfs
[Top] [All Lists]

Re: [PATCH 4/6] libxfs: reused invalidated buffers leak state and data

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/6] libxfs: reused invalidated buffers leak state and data
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 5 Jul 2014 02:48:07 -0700
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20140704222210.GM9508@dastard>
References: <1404453435-1915-1-git-send-email-david@xxxxxxxxxxxxx> <1404453435-1915-5-git-send-email-david@xxxxxxxxxxxxx> <20140704141509.GB29520@xxxxxxxxxxxxx> <20140704222210.GM9508@dastard>
User-agent: Mutt/1.5.23 (2014-03-12)
On Sat, Jul 05, 2014 at 08:22:10AM +1000, Dave Chinner wrote:
> I'm open to other ways of fixing this, but right now we've got to
> fix xfs_repair because it's currently breaking filesystems worse
> than before xfs_repair was run...

Ok, so clearly mark this as difference from kernel code in a long
comment explaining the situation similar to wrote you above.  It's
pretty obvious that the buffer cache in userspace will eventually need
a major overhaul sooner or later.  I wonder how feasible porting the
kernel one would be..

<Prev in Thread] Current Thread [Next in Thread>