xfs
[Top] [All Lists]

Re: [PATCH 4/4] repair: get rid of BADFSINO

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] repair: get rid of BADFSINO
From: Arkadiusz MiÅkiewicz <arekm@xxxxxxxx>
Date: Tue, 1 Jul 2014 15:43:49 +0200
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maven.pl; s=maven; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; bh=zQC1jaS/na4Klqx3FgKdmaRS7KlsqdRWI75rb2PALpg=; b=ldPmh2M249sIKLg3XdP4AG7FNC5vzSKiootZLxCQI13LQU1PotHTwH2hvHHny5GgnL MQQBO0eQxwNfm6/25OxYQFCgETc49hNW2o/hDl+DyxskqxVfY4eLkp9BKEJa5xypkVdP RebJ1rg5YilKEI+FHUoq7NYeT33Hb6NH5HrEc=
In-reply-to: <1404219296-29302-5-git-send-email-david@xxxxxxxxxxxxx>
References: <1404219296-29302-1-git-send-email-david@xxxxxxxxxxxxx> <1404219296-29302-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent: KMail/1.13.7 (Linux/3.16.0-rc3-00006-g16874b2; KDE/4.13.2; x86_64; ; )
On Tuesday 01 of July 2014, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>

> so get rid of BADFSINO and only use the name junking to mark
> dirents as bad. This prevents the directory data block verifier from
> triggering on bad inode numbers, and so the later reread of the
> block will find the junked entries correctly.
> 
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
>  repair/dir2.c | 18 +++++-------------
>  1 file changed, 5 insertions(+), 13 deletions(-)


> @@ -1427,11 +1419,11 @@ _("entry at block %u offset %" PRIdPTR " in
> directory inode %" PRIu64 " has ille /*
>                * Now we can mark entries with BADFSINO's bad.
>                */

Comment above needs update.

> -             if (!no_modify && ent_ino == BADFSINO) {
> -                     dep->name[0] = '/';
> +             if (!no_modify && dep->name[0] == '/') {
>                       *dirty = 1;
>                       junkit = 0;
>               }
> +
>               /*
>                * Special .. entry processing.
>                */


-- 
Arkadiusz MiÅkiewicz, arekm / maven.pl

<Prev in Thread] Current Thread [Next in Thread>