[Top] [All Lists]

Re: [PATCH v2 3/6] xfs: add xfs_mount sysfs kobject

To: Brian Foster <bfoster@xxxxxxxxxx>
Subject: Re: [PATCH v2 3/6] xfs: add xfs_mount sysfs kobject
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 28 Jun 2014 10:56:17 +1000
Cc: xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1403870821-20143-4-git-send-email-bfoster@xxxxxxxxxx>
References: <1403870821-20143-1-git-send-email-bfoster@xxxxxxxxxx> <1403870821-20143-4-git-send-email-bfoster@xxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Jun 27, 2014 at 08:06:58AM -0400, Brian Foster wrote:
> Embed a base kobject into xfs_mount. This creates a kobject associated
> with each XFS mount and a subdirectory in sysfs with the name of the
> filesystem. The subdirectory lifecycle matches that of the mount. Also
> add the new xfs_sysfs.[c,h] source files with some XFS sysfs
> infrastructure to facilitate attribute creation.
> Note that there are currently no attributes exported as part of the
> xfs_mount kobject. It exists solely to serve as a per-mount container
> for child objects.
> Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>

One minor thing I can clean up directly:

> +static inline int
> +xfs_sysfs_init(
> +     struct xfs_kobj         *kobj,
> +     struct kobj_type        *ktype,
> +     struct xfs_kobj         *p_kobj,

parent_kobj would be better - that looks too much like hungarian
notation... :)

Other than that,

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>