xfs
[Top] [All Lists]

[PATCH 4/6] xfs: add xlog sysfs kobject and attribute handlers

To: xfs@xxxxxxxxxxx
Subject: [PATCH 4/6] xfs: add xlog sysfs kobject and attribute handlers
From: Brian Foster <bfoster@xxxxxxxxxx>
Date: Fri, 6 Jun 2014 09:13:32 -0400
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1402060414-22075-1-git-send-email-bfoster@xxxxxxxxxx>
References: <1402060414-22075-1-git-send-email-bfoster@xxxxxxxxxx>
Embed a kobject into the xfs log data structure (xlog). This creates a
'log' subdirectory for every XFS mount instance in sysfs. The lifecycle
of the log kobject is tied to the lifecycle of the log.

Also define a set of generic attribute handlers associated with the log
kobject in preparation for the addition of attributes.

Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---
 fs/xfs/xfs_log.c      |  9 +++++++++
 fs/xfs/xfs_log_priv.h |  3 +++
 fs/xfs/xfs_sysfs.c    | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++
 fs/xfs/xfs_sysfs.h    |  1 +
 4 files changed, 66 insertions(+)

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 292308d..8eb10d5 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -34,6 +34,7 @@
 #include "xfs_trace.h"
 #include "xfs_fsops.h"
 #include "xfs_cksum.h"
+#include "xfs_sysfs.h"
 
 kmem_zone_t    *xfs_log_ticket_zone;
 
@@ -707,6 +708,11 @@ xfs_log_mount(
                }
        }
 
+       error = xfs_sysfs_init(&mp->m_log->l_kobject, &xfs_log_ktype,
+                       &mp->m_log->l_kobject_complete, &mp->m_kobject, "log");
+       if (error)
+               goto out_destroy_ail;
+
        /* Normal transactions can now occur */
        mp->m_log->l_flags &= ~XLOG_ACTIVE_RECOVERY;
 
@@ -947,6 +953,9 @@ xfs_log_unmount(
        xfs_log_quiesce(mp);
 
        xfs_trans_ail_destroy(mp);
+
+       xfs_sysfs_del(&mp->m_log->l_kobject, &mp->m_log->l_kobject_complete);
+
        xlog_dealloc_log(mp->m_log);
 }
 
diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
index 9bc403a..ce1eee2 100644
--- a/fs/xfs/xfs_log_priv.h
+++ b/fs/xfs/xfs_log_priv.h
@@ -405,6 +405,9 @@ struct xlog {
        struct xlog_grant_head  l_reserve_head;
        struct xlog_grant_head  l_write_head;
 
+       struct kobject          l_kobject;
+       struct completion       l_kobject_complete;
+
        /* The following field are used for debugging; need to hold icloglock */
 #ifdef DEBUG
        char                    *l_iclog_bak[XLOG_MAX_ICLOGS];
diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
index 41365fe..f837527 100644
--- a/fs/xfs/xfs_sysfs.c
+++ b/fs/xfs/xfs_sysfs.c
@@ -54,3 +54,56 @@ xfs_mp_release(struct kobject *kobj)
 struct kobj_type xfs_mp_ktype = {
        .release = xfs_mp_release,
 };
+
+/* xlog */
+
+static struct attribute *xfs_log_attrs[] = {
+       NULL,
+};
+
+STATIC ssize_t
+xfs_log_show(
+       struct kobject          *kobj,
+       struct attribute        *attr,
+       char                    *buf)
+{
+       struct xlog *log = container_of(kobj, struct xlog, l_kobject);
+       struct xfs_sysfs_attr *xfs_attr = container_of(attr,
+               struct xfs_sysfs_attr, attr);
+
+       return xfs_attr->show ? xfs_attr->show(buf, log) : 0;
+}
+
+STATIC ssize_t
+xfs_log_store(
+       struct kobject          *kobj,
+       struct attribute        *attr,
+       const char              *buf,
+       size_t                  count)
+{
+       struct xlog *log = container_of(kobj, struct xlog, l_kobject);
+       struct xfs_sysfs_attr *xfs_attr = container_of(attr,
+               struct xfs_sysfs_attr, attr);
+
+       return xfs_attr->store ? xfs_attr->store(buf, count, log) : 0;
+}
+
+static struct sysfs_ops xfs_log_ops = {
+       .show = xfs_log_show,
+       .store = xfs_log_store,
+};
+
+STATIC void
+xfs_log_release(struct kobject *kobj)
+{
+       struct xlog *log = container_of(kobj, struct xlog, l_kobject);
+
+       complete(&log->l_kobject_complete);
+}
+
+struct kobj_type xfs_log_ktype = {
+       .release = xfs_log_release,
+       .sysfs_ops = &xfs_log_ops,
+       .default_attrs = xfs_log_attrs,
+};
+
diff --git a/fs/xfs/xfs_sysfs.h b/fs/xfs/xfs_sysfs.h
index c885acf..469f218 100644
--- a/fs/xfs/xfs_sysfs.h
+++ b/fs/xfs/xfs_sysfs.h
@@ -20,6 +20,7 @@
 #define __XFS_SYSFS_H__
 
 extern struct kobj_type xfs_mp_ktype;  /* xfs_mount */
+extern struct kobj_type xfs_log_ktype; /* xlog */
 
 static inline int
 xfs_sysfs_init(
-- 
1.8.3.1

<Prev in Thread] Current Thread [Next in Thread>