| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs() |
| From: | Brian Foster <bfoster@xxxxxxxxxx> |
| Date: | Fri, 6 Jun 2014 09:13:29 -0400 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1402060414-22075-1-git-send-email-bfoster@xxxxxxxxxx> |
| References: | <1402060414-22075-1-git-send-email-bfoster@xxxxxxxxxx> |
xfs_mountfs() has a couple failure conditions that do not jump to the
correct labels. Specifically:
- xfs_initialize_perag_data() failure does not deallocate the log even
though it occurs after log initialization
- xfs_mount_reset_sbqflags() failure returns the error directly rather
than jump to the error sequence
Signed-off-by: Brian Foster <bfoster@xxxxxxxxxx>
---
fs/xfs/xfs_mount.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c
index 3507cd0..8a41aba 100644
--- a/fs/xfs/xfs_mount.c
+++ b/fs/xfs/xfs_mount.c
@@ -855,7 +855,7 @@ xfs_mountfs(
!mp->m_sb.sb_inprogress) {
error = xfs_initialize_perag_data(mp, sbp->sb_agcount);
if (error)
- goto out_fail_wait;
+ goto out_log_dealloc;;
}
/*
@@ -927,7 +927,7 @@ xfs_mountfs(
xfs_notice(mp, "resetting quota flags");
error = xfs_mount_reset_sbqflags(mp);
if (error)
- return error;
+ goto out_rtunmount;
}
}
--
1.8.3.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] mm/vmscan: Do not block forever atshrink_inactive_list()., Tetsuo Handa |
|---|---|
| Next by Date: | [PATCH 2/6] xfs: add a sysfs kset, Brian Foster |
| Previous by Thread: | [PATCH 0/6] xfs sysfs support, Brian Foster |
| Next by Thread: | Re: [PATCH 1/6] xfs: fix a couple error sequence jumps in xfs_mountfs(), Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |